Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versions of IDNA UTS #46 have more flags #486

Closed
SimonSapin opened this issue Feb 14, 2019 · 1 comment
Closed

New versions of IDNA UTS #46 have more flags #486

SimonSapin opened this issue Feb 14, 2019 · 1 comment

Comments

@SimonSapin
Copy link
Member

Compare for example:

Currently we expose a public idna::uts46::Flags struct with only public fields, so adding another field is a breaking change. A new API design could make this more extensible, perhaps with a builder pattern.

Or on the contrary, should we make the idna::uts46 module private and only provide the configurationless IDNA algorithms defined in the URL Standard? (Oops, domain to ASCII has gained a beStrict boolean parameter. Though maybe this one should be exposed as a separate domain_to_ascii_strict function?)

This was referenced Feb 14, 2019
@nox
Copy link
Contributor

nox commented Jul 18, 2019

Flags is gone and we have Config now, where adding new flags isn't a breaking change anymore. Closing.

@nox nox closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants