Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track spec changes somehow #163

Closed
SimonSapin opened this issue Jan 28, 2016 · 4 comments
Closed

Track spec changes somehow #163

SimonSapin opened this issue Jan 28, 2016 · 4 comments

Comments

@SimonSapin
Copy link
Member

  1. Pick a commit of http://url.spec.whatwg.org/
  2. Go through all of it, fix rust-url where we differ or file issues. This will be slow and boring and needs to be done very carefully.
  3. Keep track of that which commit of the spec we’re up-to-date with, modulo filed issues
  4. Regularly, go through new commits on the spec repository and update code or file new issues for spec changes
@gerv
Copy link

gerv commented Oct 24, 2017

  1. needs to involve writing tests, presumably.

@SimonSapin
Copy link
Member Author

We run a copy of the tests at https://github.com/w3c/web-platform-tests/tree/master/url. If some start failing after we update them, that’s one way to find out that we probably need some code change. But ideally we’d still go through the spec’s text in case some aspect is not covered by the test suite. In this case, yes, we should write new tests and contribute them upstream.

@SimonSapin
Copy link
Member Author

(Well, not all of https://github.com/w3c/web-platform-tests/tree/master/url since we don’t have a DOM in this repo’s unit tests, but the subset based on JSON data.)

@djc
Copy link
Contributor

djc commented Aug 10, 2020

I've updated the JSON to URL Standard's current master in #623.

@djc djc closed this as completed in 680a3e1 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants