Fix UB on out-of-bounds insert() #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Mar 20, 2024
|
The nightly workflow is fixed by #346 |
maxdeviant
referenced
this pull request
in zed-industries/zed
Jul 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [smallvec](https://togithub.com/servo/rust-smallvec) | workspace.dependencies | minor | `1.11.1` -> `1.13.2` | --- ### Release Notes <details> <summary>servo/rust-smallvec (smallvec)</summary> ### [`v1.13.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.2) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.1...v1.13.2) #### What's Changed - Add more tests for UB by [@​workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/servo/rust-smallvec/pull/346](https://togithub.com/servo/rust-smallvec/pull/346) - Fix UB on out-of-bounds insert() by [@​mbrubeck](https://togithub.com/mbrubeck) in [https://github.com/servo/rust-smallvec/pull/345](https://togithub.com/servo/rust-smallvec/pull/345) **Full Changelog**: servo/rust-smallvec@v1.13.1...v1.13.2 ### [`v1.13.1`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.1) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.0...v1.13.1) - Remove the optional `get-size` feature, to avoid a cyclic dependency ([#​335](https://togithub.com/servo/rust-smallvec/issues/335)). **Full Changelog**: servo/rust-smallvec@v1.13.0...v1.13.1 ### [`v1.13.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.0) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.12.0...v1.13.0) #### What's Changed - Impl get_size::GetSize (behind feature flag) by [@​amandasaurus](https://togithub.com/amandasaurus) in [https://github.com/servo/rust-smallvec/pull/335](https://togithub.com/servo/rust-smallvec/pull/335) **Full Changelog**: servo/rust-smallvec@v1.12.0...v1.13.0 ### [`v1.12.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.12.0) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.2...v1.12.0) #### What's Changed - Add `from_const_with_len_unchecked` by [@​Expyron](https://togithub.com/Expyron) in [https://github.com/servo/rust-smallvec/pull/329](https://togithub.com/servo/rust-smallvec/pull/329) #### New Contributors - [@​Expyron](https://togithub.com/Expyron) made their first contribution in [https://github.com/servo/rust-smallvec/pull/329](https://togithub.com/servo/rust-smallvec/pull/329) **Full Changelog**: servo/rust-smallvec@v1.11.2...v1.12.0 ### [`v1.11.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.11.2) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.1...v1.11.2) #### What's Changed - Automated testing improvements by [@​waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/322](https://togithub.com/servo/rust-smallvec/pull/322) and [https://github.com/servo/rust-smallvec/pull/326](https://togithub.com/servo/rust-smallvec/pull/326) - fix: don't special-case `doc` for `feature = "const_generics"` by [@​mkroening](https://togithub.com/mkroening) in [https://github.com/servo/rust-smallvec/pull/328](https://togithub.com/servo/rust-smallvec/pull/328) - Code cleanup by [@​emilio](https://togithub.com/emilio) in [https://github.com/servo/rust-smallvec/pull/316](https://togithub.com/servo/rust-smallvec/pull/316) and [@​waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/323](https://togithub.com/servo/rust-smallvec/pull/323) - Minor tweaks to doc formatting. by [@​waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/318](https://togithub.com/servo/rust-smallvec/pull/318) #### New Contributors - [@​mkroening](https://togithub.com/mkroening) made their first contribution in [https://github.com/servo/rust-smallvec/pull/328](https://togithub.com/servo/rust-smallvec/pull/328) **Full Changelog**: servo/rust-smallvec@v1.11.1...v1.11.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
CharlesChen0823
referenced
this pull request
in CharlesChen0823/zed
Jul 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [smallvec](https://togithub.com/servo/rust-smallvec) | workspace.dependencies | minor | `1.11.1` -> `1.13.2` | --- ### Release Notes <details> <summary>servo/rust-smallvec (smallvec)</summary> ### [`v1.13.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.2) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.1...v1.13.2) #### What's Changed - Add more tests for UB by [@&zed-industries#8203;workingjubilee](https://togithub.com/workingjubilee) in [https://github.com/servo/rust-smallvec/pull/346](https://togithub.com/servo/rust-smallvec/pull/346) - Fix UB on out-of-bounds insert() by [@&zed-industries#8203;mbrubeck](https://togithub.com/mbrubeck) in [https://github.com/servo/rust-smallvec/pull/345](https://togithub.com/servo/rust-smallvec/pull/345) **Full Changelog**: servo/rust-smallvec@v1.13.1...v1.13.2 ### [`v1.13.1`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.1) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.0...v1.13.1) - Remove the optional `get-size` feature, to avoid a cyclic dependency ([#&zed-industries#8203;335](https://togithub.com/servo/rust-smallvec/issues/335)). **Full Changelog**: servo/rust-smallvec@v1.13.0...v1.13.1 ### [`v1.13.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.0) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.12.0...v1.13.0) #### What's Changed - Impl get_size::GetSize (behind feature flag) by [@&zed-industries#8203;amandasaurus](https://togithub.com/amandasaurus) in [https://github.com/servo/rust-smallvec/pull/335](https://togithub.com/servo/rust-smallvec/pull/335) **Full Changelog**: servo/rust-smallvec@v1.12.0...v1.13.0 ### [`v1.12.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.12.0) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.2...v1.12.0) #### What's Changed - Add `from_const_with_len_unchecked` by [@&zed-industries#8203;Expyron](https://togithub.com/Expyron) in [https://github.com/servo/rust-smallvec/pull/329](https://togithub.com/servo/rust-smallvec/pull/329) #### New Contributors - [@&zed-industries#8203;Expyron](https://togithub.com/Expyron) made their first contribution in [https://github.com/servo/rust-smallvec/pull/329](https://togithub.com/servo/rust-smallvec/pull/329) **Full Changelog**: servo/rust-smallvec@v1.11.2...v1.12.0 ### [`v1.11.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.11.2) [Compare Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.1...v1.11.2) #### What's Changed - Automated testing improvements by [@&zed-industries#8203;waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/322](https://togithub.com/servo/rust-smallvec/pull/322) and [https://github.com/servo/rust-smallvec/pull/326](https://togithub.com/servo/rust-smallvec/pull/326) - fix: don't special-case `doc` for `feature = "const_generics"` by [@&zed-industries#8203;mkroening](https://togithub.com/mkroening) in [https://github.com/servo/rust-smallvec/pull/328](https://togithub.com/servo/rust-smallvec/pull/328) - Code cleanup by [@&zed-industries#8203;emilio](https://togithub.com/emilio) in [https://github.com/servo/rust-smallvec/pull/316](https://togithub.com/servo/rust-smallvec/pull/316) and [@&zed-industries#8203;waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/323](https://togithub.com/servo/rust-smallvec/pull/323) - Minor tweaks to doc formatting. by [@&zed-industries#8203;waywardmonkeys](https://togithub.com/waywardmonkeys) in [https://github.com/servo/rust-smallvec/pull/318](https://togithub.com/servo/rust-smallvec/pull/318) #### New Contributors - [@&zed-industries#8203;mkroening](https://togithub.com/mkroening) made their first contribution in [https://github.com/servo/rust-smallvec/pull/328](https://togithub.com/servo/rust-smallvec/pull/328) **Full Changelog**: servo/rust-smallvec@v1.11.1...v1.11.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
problame
added a commit
to neondatabase/neon
that referenced
this pull request
Nov 17, 2024
](https://renovatebot.com){kind=link}
Smallvec 1.13.2 contains [an UB fix](servo/rust-smallvec#345). Upstream opened [a request](rustsec/advisory-db#1960) for this in the advisory-db but it never got acted upon. Found while working on #9321.
problame
added a commit
to neondatabase/neon
that referenced
this pull request
Nov 17, 2024
Smallvec 1.13.2 contains [an UB fix](servo/rust-smallvec#345). Upstream opened [a request](rustsec/advisory-db#1960) for this in the advisory-db but it never got acted upon. Found while working on #9321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #343.