-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a proxy / agent option is ignored #142
Comments
There isn’t any One possibility is we add it to https://github.com/serviejs/popsicle-transport-http or revive the plugin you mentioned and it’ll only support HTTP1 for now. I’m actually not entirely sure how to proxy over HTTP2 which is why I haven’t build a generic utility again. Would HTTP1 only be acceptable for now? Edit: Looking into how the proxy is implemented, I should be able to add proxying with HTTP2 support. I can make an attempt this week or weekend. |
Thanks for the quick response, and thanks for looking into it! Let me know if I can help in any way. |
I fell way behind on this but made good progress this weekend. I've refactored some of the underlying HTTP transport in node.js to accept socket creation asynchronously (mostly in serviejs/popsicle-transport-http@b31ab39). With this in place I can release a new major version and add support for HTTP proxies via a configuration option that just returns a proxy asynchronously. I'll look at creating that plugin this week. |
Using
popsicle.fetch
theagent
option seems to be ignored.I'm unable to use a proxy with popsicle for that reason, passing
agent
e.g. tonode-fetch
works fine.popsicle-proxy-agent
which is deprecated and uses a functioncreateTransport
which doesn't seem to exist anymore also suggests just passingagent
now.I tried looking at the code of both
toFetch
andserviejs
but got no clue how to accomplish this.The text was updated successfully, but these errors were encountered: