Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish servicebinding.io/v1 API #395

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Publish servicebinding.io/v1 API #395

merged 1 commit into from
Mar 12, 2024

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Feb 28, 2024

servicebinding.io/v1beta1 remains supported. There is no difference in functionality between v1 and v1beta1. v1beta1 is defined in the semantics of v1, along with v1alpha3 (which remains deprecated, yet functional).

We can choose to deprecate v1beta1 in the future.

Refs servicebinding/spec#226

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 75.97403% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 78.43%. Comparing base (e741a70) to head (a8721d0).

Files Patch % Lines
dies/v1/servicebinding.go 0.00% 40 Missing ⚠️
dies/v1/clusterworkloadresourcemapping.go 0.00% 16 Missing ⚠️
apis/v1/servicebinding_webhook.go 90.00% 7 Missing and 1 partial ⚠️
apis/v1/clusterworkloadresourcemapping_webhook.go 95.29% 4 Missing ⚠️
controllers/webhook_controller.go 77.77% 2 Missing ⚠️
...is/v1/clusterworkloadresourcemapping_conversion.go 0.00% 1 Missing ⚠️
apis/v1/servicebinding_conversion.go 0.00% 1 Missing ⚠️
controllers/servicebinding_controller.go 96.55% 1 Missing ⚠️
projector/binding.go 96.42% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          19       19           
  Lines        1354     1354           
=======================================
  Hits         1062     1062           
  Misses        219      219           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's hold on merging this until the spec has released v1 resources.

servicebinding.io/v1beta1 remains supported. There is no difference in
functionality between v1 and v1beta1. v1beta1 is defined in the
semantics of v1, along with v1alpha3 (which remains deprecated, yet
functional).

We can choose to deprecate v1beta1 in the future.

Signed-off-by: Scott Andrews <[email protected]>
@scothis scothis merged commit 141fb37 into main Mar 12, 2024
24 of 25 checks passed
@scothis scothis deleted the servicebinding-v1 branch March 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants