-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce naming conventions #671
Comments
Agree, will do pr for it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Let's use Kubernetes convention for naming: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/ They are based on RFC1123, so it's safe for DNS too. |
Hmmm, I think we should support _ for naming, without the need of escaping it |
I think we should allow _ in the id, there is always the possibility of mapping it to - when being used as k8s label. Besides that I think ids can include more special characters than functions (-,_,&,!) |
What would you like to be added:
Enforce naming conventions of most (if not all) components.
I propose that we enforce using snake and/or kebab cased names.
Why is this needed:
In the case of
functionDefs
of typeexpression
, for example, not enforcing a naming convention makes expression parsing a huge mess.Consider the following example:
Now to call the function in an expression as defined by the spec, you'd need to write something like:
. | . * { "greetings": "fn:Say Hello" }
... which is impossible to parse both properly and/or safely. We could of course mandate to put the function's name between parenthesis (ex:
$fn:(Say Hello)
), for example, but I think the easier and cleanier approach is to go with a naming conventionThe text was updated successfully, but these errors were encountered: