fix(aws, apigateway): make StatusCode property compliant with AWS-documented types #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umented types for AWS::ApiGateway::Method objects
Codecov Report
@@ Coverage Diff @@
## master #7977 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 242 242
Lines 9146 9146
=======================================
Hits 8061 8061
Misses 1085 1085
Continue to review full report at Codecov.
|
medikoo
suggested changes
Jul 23, 2020
| @@ -159,7 +159,7 @@ module.exports = { | |||
| ); | |||
|
|
|||
| const integrationResponse = { | |||
| StatusCode: parseInt(statusCode, 10), | |||
| StatusCode: parseInt(statusCode, 10).toString(), | |||
There was a problem hiding this comment.
Let's just put statusCode (note that in original code string is converted to number, instead of reconverting obtained number to string, let's just not convert to number)
There was a problem hiding this comment.
Right! Missed that 👍
| @@ -36,7 +36,7 @@ module.exports = { | |||
| const methodResponse = { | |||
| ResponseParameters: {}, | |||
| ResponseModels: {}, | |||
| StatusCode: parseInt(statusCode, 10), | |||
| StatusCode: parseInt(statusCode, 10).toString(), | |||
medikoo
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
AWS::ApiGateway::Methodresources, make MethodResponse and IntegrationResponseStatusCodeproperty type-compliant with AWS-documented types to avoid validation errors on compiled CloudFormation templates.Closes: #7970