Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS API Gateway key names resolution #7804

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 2, 2020

Regression introduced by #5982, with which new format was introduced but resolution of API key names was not updated to it.

Exposed by changes introduced with #7748 in CI run: https://travis-ci.org/github/serverless/serverless/jobs/692075909

Regression introduced by #5982, with which new format was introduced, and resolution of API key names was not updated to it
@codecov-commenter
Copy link

Codecov Report

Merging #7804 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7804      +/-   ##
==========================================
- Coverage   88.20%   88.17%   -0.03%     
==========================================
  Files         245      245              
  Lines        9302     9305       +3     
==========================================
  Hits         8205     8205              
- Misses       1097     1100       +3     
Impacted Files Coverage Δ
lib/plugins/aws/info/getApiKeyValues.js 82.75% <0.00%> (-9.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011e3e2...e263943. Read the comment docs.

@medikoo medikoo merged commit f9f6a3b into master Jun 2, 2020
@medikoo medikoo deleted the 0602-fix-api-keys-resolution branch June 2, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants