-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(httpApi): external authorizer #7789
feat(httpApi): external authorizer #7789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7789 +/- ##
==========================================
+ Coverage 88.13% 88.21% +0.08%
==========================================
Files 245 245
Lines 9262 9300 +38
==========================================
+ Hits 8163 8204 +41
+ Misses 1099 1096 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michsior14 great thanks for giving that a spin.
Still, in first place we need to agree on an implementation in scope of an issue (#7598).
There was already an implementation spec proposed there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Michsior14 It looks really good! I’ve proposed few last minor improvements and we should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michsior14 looks great! Posted just one final suggestion, to keep in-logic validation simpler, and we should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Michsior14 !
This allows to add external authorizer to
httpApi
event in similar manner tohttp
event.Closes: #7598