Update json-refs lib #7763
Merged
Update json-refs lib #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericbarthelet
force-pushed
the
update-json-refs
branch
from
9a6cd85 to
6b10630
Compare
Codecov Report
@@ Coverage Diff @@
## master #7763 +/- ##
==========================================
- Coverage 88.11% 88.10% -0.01%
==========================================
Files 246 246
Lines 9279 9275 -4
==========================================
- Hits 8176 8172 -4
Misses 1103 1103
Continue to review full report at Codecov.
|
medikoo
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7691
Had to replace
options.relativeBasewithoptions.locationfor relative reference resolution (cf https://github.com/whitlockjc/json-refs/blob/master/RELEASE_NOTES.md#v300-2017-04-25). Location uses the root file location instead of the base path, thus removing parentDir computation part.