Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-uuid module is deprecated #2767

Closed
eahefnawy opened this issue Nov 22, 2016 · 4 comments
Closed

node-uuid module is deprecated #2767

eahefnawy opened this issue Nov 22, 2016 · 4 comments
Assignees
@pmuens
Labels
bug
Milestone
1.9

Comments

@eahefnawy
Copy link
Contributor

ditch the [email protected] deprecated module:

Eslams-MacBook-Pro:serverless eslam$ npm install
npm WARN deprecated [email protected]: use uuid module instead
...
@eahefnawy eahefnawy added this to the 1.3 milestone Nov 22, 2016
@pmuens pmuens self-assigned this Nov 22, 2016
@pmuens
Copy link
Contributor

pmuens commented Nov 22, 2016

Just looked into this one.

We use uuid but coveralls uses request which uses node-uuid:

[email protected] /app
`-- [email protected]
  `-- [email protected]
    `-- [email protected]

I've looked into the most recent coveralls version which still uses [email protected] so we have to wait until coveralls updates their request dependency (which already has the fix).

@nikgraf nikgraf modified the milestones: 1.4, 1.3 Nov 24, 2016
@mthenw mthenw added refactor and removed bug labels Nov 30, 2016
@pmuens
Copy link
Contributor

pmuens commented Dec 5, 2016

Just looked at it again. Still no version bump:

https://github.com/nickmerwin/node-coveralls/blob/master/package.json#L37
nickmerwin/node-coveralls#133

@nikgraf nikgraf modified the milestones: 1.5, 1.4 Dec 5, 2016
@pmuens
Copy link
Contributor

pmuens commented Jan 3, 2017

Moving to 1.6 since node-coveralls is still not updated...

@pmuens pmuens modified the milestones: 1.6, 1.5 Jan 3, 2017
@pmuens pmuens removed the priority/P1 label Jan 4, 2017
@DavidWells DavidWells self-assigned this Jan 7, 2017
@eahefnawy eahefnawy removed this from the 1.6 milestone Jan 26, 2017
@pmuens
Copy link
Contributor

pmuens commented Mar 3, 2017

It happened!!! 🎉

https://github.com/nickmerwin/node-coveralls/blob/master/package.json#L37

@pmuens pmuens added this to the 1.9 milestone Mar 3, 2017
@pmuens pmuens mentioned this issue Mar 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuens pmuens

Labels
bug
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
7 participants
@nikgraf @mthenw @DavidWells @brianneisler @worldsoup @pmuens @eahefnawy