-
Notifications
You must be signed in to change notification settings - Fork 161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean! Definitely makes the experience nicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, approved before pulling this down and running. It looks like the new AzureApimPlugin
is setting up a deploy
lifecycle event. Lines 11 and 17 of azureApimPlugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
src/services/baseService.ts
Outdated
@@ -196,7 +194,7 @@ export abstract class BaseService { | |||
* Log message to Serverless CLI | |||
* @param message Message to log | |||
*/ | |||
protected log(message: string, options?: ServerlessLogOptions, entity?: string,) { | |||
protected log(message: string, options?: ServerlessLogOptions, entity?: string, ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Remove last comma and empty space from method header
APIM configuration can easily bloat your serverless configuration yaml. This PR reduces a lot of the boilerplate APIM configuration in many use cases except for when direct customization is required. Infers APIM operation configuration from HTTP binding Will automatically generate API just by setting apm: true in serverless yaml Will automatically generate default backend pointing to the /api endpoint of your function app Now supports configuring multiple API's in a single configuration Now supports configuring multiple Backends in a single configuration Ability to link an APIM operation to a specific API and backend
APIM configuration can easily bloat your serverless configuration yaml. This PR reduces a lot of the boilerplate APIM configuration in many use cases except for when direct customization is required.
apm: true
in serverless yaml/api
endpoint of your function app