This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
feat: Add hooks type to base plugin, document plugin options for CLI help
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Aug 16, 2019
|
|
||
| this.commands = { | ||
| remove: { | ||
| usage: "Remove service resource group (USE WITH CAUTION)", |
There was a problem hiding this comment.
eeep, is there a way to enforce confirmation with this command?
There was a problem hiding this comment.
Not currently, no
|
LGTM |
pjlittle
approved these changes
Aug 16, 2019
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
…I help (#245) - [x] Added `commands` to all plugins - [x] Added `resourceGroup`, `stage`, `region` and `subscriptionId` to all CLI commands that need to log into Azure - [x] Refactored `hooks` and `commands` to exist at the `BasePlugin` level - [x] Added type `ServerlessHookMap` Resolves AB#802 and AB#795
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandsto all pluginsresourceGroup,stage,regionandsubscriptionIdto all CLI commands that need to log into Azurehooksandcommandsto exist at theBasePluginlevelServerlessHookMapResolves AB#802 and AB#795