This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
feat: Added Azure Naming Service #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlittle
reviewed
Aug 1, 2019
src/services/namingService.ts
Outdated
| if (suffix) { | ||
| name += `-${suffix}`; | ||
| } | ||
| return name; |
There was a problem hiding this comment.
I can't think of a great reason why, but would we want to .toLowerCase() this, just to normalize? Also, guessing it's unsupported, but has anyone tried extended ascii or double-byte chars?
nvm.. i think this is answered in getSafeResourceName below...
|
LGTM - thanks for centralizing this logic and updating across the board 👍 |
pjlittle
approved these changes
Aug 1, 2019
mydiemho
approved these changes
Aug 1, 2019
src/services/baseService.ts
Outdated
| @@ -116,8 +123,8 @@ export abstract class BaseService { | |||
| */ | |||
| protected getArtifactName(deploymentName: string): string { | |||
| return `${deploymentName | |||
| .replace("rg-deployment", "artifact") | |||
| .replace("deployment", "artifact")}.zip`; | |||
| .replace(`rg-${configConstants.naming.suffix.deployment}`, configConstants.naming.suffix.artifact) | |||
There was a problem hiding this comment.
nit: extract configConstants.naming.suffix.deployment and configConstants.naming.suffix.artifact into local variables
wbreza
approved these changes
Aug 1, 2019
src/services/baseService.ts
Outdated
| @@ -43,7 +44,7 @@ export abstract class BaseService { | |||
| this.deploymentConfig = this.getDeploymentConfig(); | |||
| this.deploymentName = this.getDeploymentName(); | |||
| this.storageAccountName = StorageAccountResource.getResourceName( | |||
There was a problem hiding this comment.
Can likely just keep this as 1 line now.
tbarlow12
force-pushed
the
tabarlow/new-naming-service
branch
from
77804a1 to
17a026d
Compare
tbarlow12
force-pushed
the
tabarlow/new-naming-service
branch
from
17a026d to
92e8d0f
Compare
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
- [x] Add `AzureNamingService` - [x] Move naming utils to naming service - [x] Added `getSafeResourceName` - used by `storageAccount` and `deploymentName` Resolves [AB#597]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureNamingServicegetSafeResourceName- used bystorageAccountanddeploymentNameResolves [AB#597]