Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

feat: Azure API management #157

Merged
merged 18 commits into from
Jun 6, 2019
Merged

feat: Azure API management #157

merged 18 commits into from
Jun 6, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Jun 1, 2019

  • Adds better logging for API management (displays function urls)
  • Adds unit tests
  • Updates configuration for better Jest debugging

@wbreza wbreza requested review from mydiemho and tbarlow12 June 1, 2019 01:40
tbarlow12
tbarlow12 suggested changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Tested the debugging, working a lot better. I know you said you had some changes to make still. Added a few questions & follow up items to sync on.

package.json Show resolved Hide resolved
src/plugins/deploy/azureDeployPlugin.test.ts Outdated Show resolved Hide resolved
src/plugins/login/loginPlugin.ts Outdated Show resolved Hide resolved
src/plugins/package/azurePackage.test.ts Outdated Show resolved Hide resolved
src/services/apimService.test.ts Outdated Show resolved Hide resolved
src/services/apimService.ts Show resolved Hide resolved
src/services/baseService.ts Outdated Show resolved Hide resolved
src/services/functionAppService.ts Show resolved Hide resolved
src/test/mockFactory.ts Show resolved Hide resolved
src/test/responses/apim-get-api-404.json Show resolved Hide resolved
@wbreza wbreza force-pushed the wabrez/show-function-urls branch from e27d1aa to e89d394 Compare June 4, 2019 00:01
@wbreza wbreza force-pushed the wabrez/show-function-urls branch from e89d394 to b20985d Compare June 4, 2019 23:11
tbarlow12
tbarlow12 approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great :shipit:

PIC123
PIC123 approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pjlittle
pjlittle reviewed Jun 6, 2019
View reviewed changes
package.json Show resolved Hide resolved
@wbreza wbreza merged commit 2364a84 into dev Jun 6, 2019
@tbarlow12 tbarlow12 deleted the wabrez/show-function-urls branch September 9, 2019 13:47
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
@wbreza @tbarlow12
feat: Azure API management (#157)
0f54201 
- Adds better logging for API management (displays function urls)
- Adds unit tests
- Updates configuration for better Jest debugging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjlittle pjlittle pjlittle left review comments

@tbarlow12 tbarlow12 tbarlow12 approved these changes

@PIC123 PIC123 PIC123 approved these changes

@mydiemho mydiemho Awaiting requested review from mydiemho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wbreza @pjlittle @PIC123 @tbarlow12