This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
feat: Converted project to typescript #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `loginToAzure` refs
Make plugins directory typescript compatible
mydiemho
approved these changes
May 20, 2019
| "author": "Azure Functions", | ||
| "scripts": { | ||
| "test": "eslint **/*.js" | ||
| "test": "eslint src/**/*.js", | ||
| "prebuild": "rm lib/ -rf && npm test", |
There was a problem hiding this comment.
Any advantage of putting flags before? My habit is to put them after.
| bearer: 'Bearer ', | ||
| functionAppApiPath: '/api/', | ||
| functionAppDomain: '.azurewebsites.net', | ||
| functionsAdminApiPath: '.azurewebsites.net/admin/functions/', | ||
| functionsAdminApiPath: '/admin/functions/', |
There was a problem hiding this comment.
are function and functions referring to 2 different things?
There was a problem hiding this comment.
This is a partial path to one of the Kudu rest endpoints to retrieve functions in a function app.
| bearer: 'Bearer ', | ||
| functionAppApiPath: '/api/', | ||
| functionAppDomain: '.azurewebsites.net', | ||
| functionsAdminApiPath: '.azurewebsites.net/admin/functions/', | ||
| functionsAdminApiPath: '/admin/functions/', | ||
| functionsApiPath: '/api/functions', | ||
| jsonContentType: 'application/json', | ||
| logInvocationsApiPath: '/azurejobs/api/functions/definitions/', |
There was a problem hiding this comment.
consistency: some path end with / and some don't
There was a problem hiding this comment.
I think it's because some of these will be appended to others. For example {functionAppDomain} + {functionsApiPath}. The / is included in the second one.
| }; | ||
|
|
||
| export default constants; |
There was a problem hiding this comment.
style: new line in file or not? we should decide on one and add to editorconfig
tbarlow12
approved these changes
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loginplugin to handle azure loginAPIMplugin for integration with Azure API managementDeployplugin