Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CORS configuration from subscription #458

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Remove CORS configuration from subscription #458

merged 1 commit into from
Jun 8, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 8, 2018

What did you implement:

Part of #438

How did you implement it:

It removes the remainings of CORS configuration in subscription model.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #458 into master will decrease coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   66.17%   66.06%   -0.12%     
==========================================
  Files          32       32              
  Lines        1892     1877      -15     
==========================================
- Hits         1252     1240      -12     
+ Misses        587      585       -2     
+ Partials       53       52       -1
Impacted Files Coverage Δ
internal/cache/target.go 0% <0%> (ø) ⬆️
internal/cache/subscription_cache.go 86.76% <100%> (ø) ⬆️
libkv/subscription.go 88.6% <100%> (+0.58%) ⬆️
internal/pathtree/tree.go 97.22% <87.5%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb5ea9...699cf9d. Read the comment docs.

@mthenw mthenw merged commit 1c89d5c into master Jun 8, 2018
@mthenw mthenw deleted the remove-cors branch June 8, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant