Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI friendly logging #706

Closed
vicary opened this issue Oct 22, 2020 · 5 comments
Closed

CI friendly logging #706

vicary opened this issue Oct 22, 2020 · 5 comments

Comments

@vicary
Copy link

vicary commented Oct 22, 2020

Is your feature request related to a problem? Please describe.
The deploy timer is nice when working with normal shells, but CI logs, or outputs piped to a file in general does not play nice with the /r line replacement.

Describe the solution you'd like
I would like the deployment script to either expose a CLI option (e.g. --ci), or read a commonly used environment variable CI=true.

Describe alternatives you've considered
None exists, we have to manually scroll through 10k lines if it ends up with errors.

Additional context
image

@dphang
Copy link
Collaborator

dphang commented Oct 22, 2020

Yes I've seen this too, but assumed this was an issue from the Serverless Framework, not this component, not sure we can do anything about it unless we change how we deploy or use new Serverless component version. @danielcondemarin any ideas?

@danielcondemarin
Copy link
Contributor

Yes I've seen this too, but assumed this was an issue from the Serverless Framework, not this component, not sure we can do anything about it unless we change how we deploy or use new Serverless component version. @danielcondemarin any ideas?

Right now I don't think there is anything we can do. My best guess is when we update to serverless components GA then this shouldn't be an issue, and if it is, then we'd close this anyway and raise it on the components core repo. Let's keep it open here for now 👍

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs

I am also having the same problem, I created an issue in https://github.com/serverless/components repo.

serverless/components#834

@dphang
Copy link
Collaborator

dphang commented Sep 9, 2021

Fixed by this: #1658. The above issue has a PR out for the GA components, but we are still using deprecated @serverless/cli so that one needed to be patched in a similar manner. You should be able to run the patched version by deploying using npx serverless-patched as a temp solution for now. Let me know if there are any issues.

@dphang dphang closed this as completed Sep 9, 2021
@herrlegno
Copy link

herrlegno commented Jan 11, 2022

Will running the patched version be the final solution? as serverless/components#834 and PR are now closed?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants