-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(domain): add domain input minimumProtocolVersion #1916
Conversation
Handler Size Report
Base Handler Sizes (kB) (commit a3b435b){
"Lambda": {
"Default Lambda": {
"Standard": 1494,
"Minified": 658
},
"Image Lambda": {
"Standard": 1460,
"Minified": 791
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 2078,
"Minified": 959
},
"Default Lambda V2": {
"Standard": 1497,
"Minified": 660
},
"API Lambda": {
"Standard": 632,
"Minified": 318
},
"Image Lambda": {
"Standard": 1468,
"Minified": 796
},
"Regeneration Lambda": {
"Standard": 1162,
"Minified": 537
},
"Regeneration Lambda V2": {
"Standard": 1227,
"Minified": 563
}
}
} New Handler Sizes (kB) (commit 7f42e6e){
"Lambda": {
"Default Lambda": {
"Standard": 1494,
"Minified": 658
},
"Image Lambda": {
"Standard": 1460,
"Minified": 791
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 2078,
"Minified": 959
},
"Default Lambda V2": {
"Standard": 1497,
"Minified": 660
},
"API Lambda": {
"Standard": 632,
"Minified": 318
},
"Image Lambda": {
"Standard": 1468,
"Minified": 796
},
"Regeneration Lambda": {
"Standard": 1162,
"Minified": 537
},
"Regeneration Lambda V2": {
"Standard": 1227,
"Minified": 563
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
- Coverage 83.92% 83.76% -0.17%
==========================================
Files 100 100
Lines 3534 3541 +7
Branches 1072 1074 +2
==========================================
Hits 2966 2966
- Misses 510 515 +5
- Partials 58 60 +2
Continue to review full report at Codecov.
|
@@ -498,6 +499,13 @@ const removeDomainFromCloudFrontDistribution = async ( | |||
}; | |||
}; | |||
|
|||
const isMinimumProtocolVersionValid = (minimumProtocolVersion) => { | |||
// https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-viewercertificate.html | |||
const validMinimumProtocolVersions = /(^SSLv3$|^TLSv1$|^TLSv1.1_2016$|^TLSv1.2_2018$|^TLSv1.2_2019$|^TLSv1.2_2021$|^TLSv1_2016$)/g; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to check this though in the future I think the AWS SDK also throws a 400 status, so you could remove this later too
Thanks, will publish it soon (sorting out some upgrades with renovate/yarn first) |
Fix for #1878