-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the serve command #152
Comments
@hassankhan Are you interested (and have time) to take care of this? Additionally to removing the command, we also have to check for then obsolete dependencies that can be removed from the project. |
I can take care of the "local invoke" (#151) which would also be a good addition to 3.0.0. |
I'll try and commit some time to it, as you said it needs to be carefully done and not break anything else. I'd add that it should probably be tested with |
I'll add the new |
I've tried to run
instead of
In the I'm happy to troubleshooting but don't know where to start. |
@franciscocpg , answered in #135 per @HyperBrain request. |
This might be a good place for tracking two pending sls-offline PRs on blocking issues for some use-cases for discarding the serve command - dherault/serverless-offline#283 |
This is a Feature Task
Description
In #135 we decided that the
serve
command will be removed because it doesnot add additional value to the Serverless framework as the
serverless-offline
integrates with the plugin and does the job even better.
This task should contain all (technical) discussions about the actual removal, so
that it can be removed without affecting the other commands/features that will stay
in the plugin.
The target milestone for the removal is version 3.0.0 as it is (by definition) a breaking change
that needs actions to be taken by users that currently use it.
All PRs for the feature have to be targeted to the (new)
v3.0.0-remove-serve
branch to keep master cleanfor any 2.x.x bugfix or feature versions. We will use this branch to stabilize the feature. The branch will be
rebased to master each time something is added there.
Similar or dependent issue(s):
serve
command #135The text was updated successfully, but these errors were encountered: