You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There should be a more in-depth check for this - at the last adding some dots in there like .s3. or something like that.
I'm actually trying to use an s3 redirect bucket like this http://{bucketName}.s3-website-eu-west-1.amazonaws.com so it's causing an issues as the redirect only works from s3-website-eu-west-1 urls not s3.amazonaws.com so had to fork and alter this.
The text was updated successfully, but these errors were encountered:
gehan
changed the title
Incorrectly assumes any url with s3 in it is an s3 bucket
Assumes any url with s3 in it is an s3 bucket
Apr 30, 2020
Currently if an origin domain contains
s3
in it anywhere then it assumes it's an s3 bucket and changes the url to${bucketName}.s3.amazonaws.com
https://github.com/serverless-components/aws-cloudfront/blob/master/lib/getOriginConfig.js#L18
There should be a more in-depth check for this - at the last adding some dots in there like
.s3.
or something like that.I'm actually trying to use an s3 redirect bucket like this
http://{bucketName}.s3-website-eu-west-1.amazonaws.com
so it's causing an issues as the redirect only works froms3-website-eu-west-1
urls nots3.amazonaws.com
so had to fork and alter this.The text was updated successfully, but these errors were encountered: