Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support profile #64

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

phyzical
Copy link

@phyzical phyzical commented Nov 15, 2024

closes #39

  • adds support for the --profile, only accepts string wrapped ints or will scream.
  • combines each threads slowest into 1 total i.e if 3 threads you will be served the slowest 10 not 30
  • added specs to try and test this

Questions:

  • i had a hard time actually building the required struct for the profile formatter as unlike the others it uses the provided params as objects instead of just being a string like i.e dump_summary
  • i couldn't actually workout a nice place to get the list of example groups from so atm it will just get all unique file locations and and descriptions based on count of how many gorups
  • i cant seem to get the exception of raising of the argument error?
image

@ilyazub i had a crack i know this is close, but it does feel like ive hacked it a bit open to any feedback!

lib/turbo_tests/runner.rb Outdated Show resolved Hide resolved
lib/turbo_tests/cli.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using config.profile_examples each thread outputs the slowest examples making the output harder to read
1 participant