Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dynamic install agent multi-times with different agent directory #1683

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Nov 26, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

Currently when users dynamic install agent at the second time, the directory of new agent can not be a custom path. So this PR aims to fix this issue

Which issue(s) this PR fixes?

Fixes #1687

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@lilai23 lilai23 changed the title 【fix】support dynamic install agent multi-times with different agent directory fix: support dynamic install agent multi-times with different agent directory Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...src/main/java/io/sermant/core/utils/FileUtils.java 60.00% 2 Missing ⚠️
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.88% <50.00%> (-0.02%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...in/java/io/sermant/core/common/CommonConstant.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...src/main/java/io/sermant/core/utils/FileUtils.java 11.70% <60.00%> (ø) 0.00 <0.00> (ø)

... and 14 files with indirect coverage changes

@Sherlockhan Sherlockhan merged commit 283eaf7 into sermant-io:develop Nov 30, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple dynamic mountings do not support different agent directories.
4 participants