Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where the service name is not checked for null when adding to the request header. #1728

Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jan 2, 2025

What type of PR is this?

Bug

What this PR does / why we need it?

Fix the issue where the service name is not checked for null when adding to the request header

Which issue(s) this PR fixes?

Fixes #1727

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

…ing to the request header.

Signed-off-by: hanbingleixue <[email protected]>
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service branch from 65c14d6 to 639d931 Compare January 2, 2025 10:45
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ant/flowcontrol/retry/FeignRequestInterceptor.java 50.00% 1 Missing and 1 partial ⚠️
...mant/flowcontrol/retry/HttpRequestInterceptor.java 75.00% 0 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 42.67% <62.50%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...mant/flowcontrol/retry/HttpRequestInterceptor.java 42.70% <75.00%> (+0.15%) 0.00 <0.00> (ø)
...ant/flowcontrol/retry/FeignRequestInterceptor.java 37.30% <50.00%> (-0.61%) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@Sherlockhan Sherlockhan merged commit c2d5831 into sermant-io:develop Jan 2, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the issue where the service name is not checked for null when adding to the request header
4 participants