Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the traffic label is lost in the HikariDataSource scenario #1719

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chengyouling
Copy link
Collaborator

What type of PR is this?

Bug.

What this PR does / why we need it?

The traffic label is lost in the HikariDataSource scenario.

Which issue(s) this PR fixes?

Fixes #1718

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@chengyouling chengyouling self-assigned this Jan 2, 2025
provenceee
provenceee previously approved these changes Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/crossthread/wrapper/AbstractThreadWrapper.java 20.00% 4 Missing ⚠️
...router/transmit/wrapper/AbstractThreadWrapper.java 60.00% 0 Missing and 2 partials ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.50% <40.00%> (-0.08%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...router/transmit/wrapper/AbstractThreadWrapper.java 55.26% <60.00%> (-32.62%) 0.00 <0.00> (ø)
...ion/crossthread/wrapper/AbstractThreadWrapper.java 33.33% <20.00%> (-1.97%) 0.00 <0.00> (ø)

... and 10 files with indirect coverage changes

@chengyouling chengyouling force-pushed the develop-cross branch 2 times, most recently from f67de0f to f3bf488 Compare January 2, 2025 06:32
@Sherlockhan Sherlockhan merged commit 7f36075 into sermant-io:develop Jan 2, 2025
164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The traffic label is lost in the HikariDataSource scenario.
4 participants