support install external agent in Sermant #1706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilai23
force-pushed
the
feature_opentelemetry
branch
from
63af395 to
d125c25
Compare
lilai23
force-pushed
the
feature_opentelemetry
branch
2 times, most recently
from
045ff7d to
63e9cb1
Compare
3 tasks
lilai23
force-pushed
the
feature_opentelemetry
branch
from
63e9cb1 to
f061590
Compare
lilai23
changed the title
lilai23
force-pushed
the
feature_opentelemetry
branch
8 times, most recently
from
9156736 to
f0e35a8
Compare
zwmagic
previously approved these changes
Dec 19, 2024
| * @throws InvocationTargetException | ||
| * @throws IllegalAccessException | ||
| */ | ||
| static void installOtelAgent(boolean isDynamic, String agentPath, Map<String, String> argsMap, |
There was a problem hiding this comment.
The code for using installCommonAgent() and installOtelAgent() is duplicated, which can be merged
There was a problem hiding this comment.
resolved as one method
daizhenyu
reviewed
Dec 20, 2024
sermant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/AgentCoreEntrance.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Dec 20, 2024
sermant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/AgentCoreEntrance.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Dec 20, 2024
sermant-agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/AgentCoreEntrance.java
Show resolved
Hide resolved
daizhenyu
reviewed
Dec 20, 2024
...gentcore-core/src/main/java/io/sermant/core/command/ExternalAgentInstallCommandExecutor.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Dec 20, 2024
...agentcore/sermant-agentcore-core/src/main/java/io/sermant/core/ext/ExternalAgentManager.java
Outdated
Show resolved
Hide resolved
lilai23
force-pushed
the
feature_opentelemetry
branch
2 times, most recently
from
fe62791 to
e5359e3
Compare
Signed-off-by: lilai <[email protected]>
lilai23
force-pushed
the
feature_opentelemetry
branch
from
e5359e3 to
02633eb
Compare
zwmagic
reviewed
Dec 20, 2024
| * | ||
| * @param startMethod the method name OpenTelemetry Agent starts by | ||
| */ | ||
| public void collectOtelStartEvent(String startMethod) { |
There was a problem hiding this comment.
make this method more general and decouple it from Otel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it?
To better integrate with OpenTelemetry and make it easier for users to leverage its observability capabilities, we aim to treat OpenTelemetry as a component within Sermant. It will support both static and dynamic attachment methods.
Which issue(s) this PR fixes？
Fixes #1705
Does this PR introduce a user-facing change?
Yes. We will update user guide at sermant.io.
Checklist