Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the common module with XDS Retry functions #1697

Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Dec 13, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

Add the common module for the XDS flow control plugin

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-common branch 2 times, most recently from 85d3882 to 3ef1291 Compare December 24, 2024 07:40
@hanbingleixue hanbingleixue changed the title Add the common module for the XDS flow control plugin Add the common module with XDS Retry functions Dec 24, 2024
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-common branch 3 times, most recently from f6e7400 to 6bfab1f Compare December 26, 2024 01:26
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 45.13889% with 79 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...control/retry/SpringLbChooseServerInterceptor.java 25.00% 11 Missing and 1 partial ⚠️
...ds/retry/condition/ConnectErrorRetryCondition.java 8.33% 11 Missing ⚠️
...flowcontrol/common/handler/retry/RetryContext.java 23.07% 10 Missing ⚠️
...ommon/xds/retry/condition/ResetErrorCondition.java 9.09% 10 Missing ⚠️
...ndition/SpecificHeaderNameErrorRetryCondition.java 16.66% 10 Missing ⚠️
...rol/retry/SpringRibbonChooseServerInterceptor.java 64.70% 3 Missing and 3 partials ⚠️
...mmon/xds/retry/condition/ClientErrorCondition.java 20.00% 4 Missing ⚠️
...mmon/xds/retry/condition/ServerErrorCondition.java 20.00% 4 Missing ⚠️
...control/common/handler/AbstractRequestHandler.java 25.00% 3 Missing ⚠️
...ndition/SpecificStatusCodeErrorRetryCondition.java 40.00% 3 Missing ⚠️
... and 4 more
Flag Coverage Δ Complexity Δ
unittests 43.84% <45.13%> (-0.03%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...java/io/sermant/core/ext/ExternalAgentManager.java 46.93% <ø> (ø) 0.00 <0.00> (ø)
...ermant/flowcontrol/common/handler/retry/Retry.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...mon/handler/retry/policy/RetryOnUntriedPolicy.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...mant/flowcontrol/retry/HttpRequestInterceptor.java 47.67% <ø> (ø) 0.00 <0.00> (ø)
...mant/flowcontrol/retry/handler/RetryHandlerV2.java 66.66% <ø> (ø) 0.00 <0.00> (ø)
...ant/flowcontrol/res4j/handler/BulkheadHandler.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...owcontrol/res4j/handler/CircuitBreakerHandler.java 80.48% <ø> (ø) 0.00 <0.00> (ø)
...ermant/flowcontrol/res4j/handler/FaultHandler.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...flowcontrol/res4j/handler/RateLimitingHandler.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...t/flowcontrol/res4j/handler/SystemRuleHandler.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
... and 14 more

@Sherlockhan Sherlockhan merged commit c66c14a into sermant-io:develop Dec 26, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
4 participants