Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor metric APIs #1598

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

zwmagic
Copy link
Collaborator

@zwmagic zwmagic commented Aug 17, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

It is hoped that Sermant will support Prometheus monitoring so that Sermant's core metrics as well as each plugin's custom metrics can be monitored through Grafana.

Which issue(s) this PR fixes?

Fixes #1445

Does this PR introduce a user-facing change?

No

Get Prometheus metric at http:// 127.0.0.1:47128/sermant/metrics

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 218 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../sermant/implement/service/metric/MeterMetric.java 0.00% 50 Missing ⚠️
...plement/service/metric/MeterMetricServiceImpl.java 0.00% 31 Missing ⚠️
...ervice/metric/api/DistributionStatisticConfig.java 0.00% 29 Missing ⚠️
.../java/io/sermant/core/service/metric/api/Tags.java 0.00% 19 Missing ⚠️
...o/sermant/implement/service/metric/MeterTimer.java 0.00% 15 Missing ⚠️
.../main/java/io/sermant/core/utils/ReflectUtils.java 0.00% 13 Missing ⚠️
...rmant/core/service/metric/config/MetricConfig.java 0.00% 10 Missing ⚠️
...o/sermant/implement/service/metric/MeterGauge.java 0.00% 9 Missing ⚠️
...sermant/implement/service/metric/MeterCounter.java 0.00% 8 Missing ⚠️
...sermant/implement/service/metric/MeterSummary.java 0.00% 8 Missing ⚠️
... and 7 more
Flag Coverage Δ Complexity Δ
unittests 43.77% <0.00%> (-0.33%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...n/java/io/sermant/core/service/ServiceManager.java 9.23% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/io/sermant/core/utils/SpiLoadUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/io/sermant/core/service/metric/api/Counter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/io/sermant/core/service/metric/api/Summary.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/io/sermant/core/service/metric/api/Gauge.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/io/sermant/core/service/ServiceConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...service/metric/handler/MetricHttpRouteHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ic/prometheus/PrometheusMeterRegistryProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...sermant/implement/service/metric/MeterCounter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...sermant/implement/service/metric/MeterSummary.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 8 more

@daizhenyu daizhenyu changed the title 监控指标APIs Monitor metric APIs Aug 19, 2024
@zwmagic zwmagic force-pushed the zwmagic/support_prometheus branch from e6562a3 to 88c856b Compare August 23, 2024 08:07
@zwmagic zwmagic force-pushed the zwmagic/support_prometheus branch 2 times, most recently from b881d73 to 4329261 Compare August 30, 2024 08:54
daizhenyu
daizhenyu previously approved these changes Sep 2, 2024
@zwmagic zwmagic force-pushed the zwmagic/support_prometheus branch from 4329261 to 06f27cc Compare September 9, 2024 12:10
@zwmagic zwmagic force-pushed the zwmagic/support_prometheus branch 2 times, most recently from 075bb2f to b0b01b3 Compare September 23, 2024 03:47
@zwmagic zwmagic force-pushed the zwmagic/support_prometheus branch from b0b01b3 to 1dee353 Compare September 23, 2024 12:35
@Sherlockhan Sherlockhan merged commit 146cd69 into sermant-io:develop Sep 24, 2024
281 of 282 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can Sermant support Prometheus monitoring?
5 participants