Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigManager#initialize phase, log warnings/errors, causing agent mount fail #1591

Closed
AYue-94 opened this issue Aug 2, 2024 · 1 comment · Fixed by #1593
Closed

ConfigManager#initialize phase, log warnings/errors, causing agent mount fail #1591

AYue-94 opened this issue Aug 2, 2024 · 1 comment · Fixed by #1593
Labels
kind/bug Something isn't working
Milestone

Comments

@AYue-94
Copy link

AYue-94 commented Aug 2, 2024

What happened?

i add myList property in config.properties and AgentConfig, and default it is empty string.

agent.config.myList=

when io.sermant.core.config.utils.ConfigValueUtil#parseConfigToCollection, parse empty string, then log warn.
image
it cause new LogEventCollector instance created, but Config is not ready, so it cause NPE, and agent mount fail.
image

How can we reproduce it (as minimally and precisely as possible)?

you can try set agent.config.serviceInjectList as empty string.

Anything else we need to know?

No response

Sermant version

2.0.0

OS version

MacOS14.1

@hanbingleixue
Copy link
Collaborator

@AYue-94 The cause of this problem is that when the configuration type of a configuration item is collection and the configuration content is empty, an warning log is recorded. The LogEventCollector collects and reports warning logs. However, the event configuration is not initialized, so a NullPointerException is thrown on event collection. We will fix it in the next release.

@lilai23 lilai23 added this to the v2.1.0 milestone Sep 27, 2024
@daizhenyu daizhenyu mentioned this issue Dec 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
3 participants