Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springcloud dual registration scenario, DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor can be optimized #1242

Closed
provenceee opened this issue Jul 6, 2023 · 0 comments
Assignees
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement

Comments

@provenceee
Copy link
Collaborator

provenceee commented Jul 6, 2023

What would you like to be added?

Optimize com.huawei.registry.interceptors.DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor

Why is this needed?

Currently, these two interception points call this method again in the interception point logic, and then use thread variables to exit. You can consider putting the logic of merging instances into the post-interception point and removing the thread variables. In addition, in the webflux scenario, use block is forced to block, you can consider changing it to non-blocking merge

@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Jul 6, 2023
@kkf1 kkf1 changed the title springcloud双注册场景,DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor可以优化 Springcloud dual registration scenario, DiscoveryClientInterceptor/DiscoveryClientServiceInterceptor can be optimized Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

No branches or pull requests

4 participants