Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors in updating the cache and report them to sentry (at least for the spreadsheets) #715

Open
kulla opened this issue Aug 17, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@kulla
Copy link
Member

kulla commented Aug 17, 2022

Sometimes in the update routine an error is raised (for example in updating the spreadsheet sometimes a timeout error occurs). Currently the update routine is written in a way, that in this case an empty spreadsheet is saved. This needs some investigation. Desired behavior:

  • Do not change the cache in case of an error
  • Report the error to sentry

The file https://github.com/serlo/api.serlo.org/blob/34d8f8b809b00abe6abf5b98b68b9d925bfce698/packages/server/src/internals/swr-queue.ts needs to be changed. See https://github.com/serlo/documentation/wiki/Cache on a documentation how the cache works.

@kulla kulla added bug Something isn't working enhancement New feature or request labels Aug 17, 2022
@kulla kulla added the good first issue Good for newcomers label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Triage
Development

No branches or pull requests

2 participants
@kulla and others