-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Serilog sink that'd use OpenTelemetry SDK #159
Comments
Hi @srogovtsev! I think @CodeBlanch had one of these in the works; I'm not sure where it landed, it may just be waiting to hit the top of the backlog :-) IIRC the project name was OpenTelemetry.Serilog.Sink. If you're keen to dig in and put one of these together independently I'd be happy to help out. I don't have a use case for it myself so not much of an opportunity to dogfood, and no bandwidth to ship or maintain it, unfortunately, but I'm curious what it would look like and how smooth the integration can get. |
Let's say, I'm interested at trying my hand at it, but I don't know what my workload would be either. But in our particular case it might be a more reasonable approach than trying to adapt |
Were it not for the overhead, this could have been achieved by simply chaining |
Just as a record, it seems that I was too hasty with this whole idea: OpenTelemetry 1.9.0 (the latest at the time of writing) is very closed WRT logging infrastructure, so doing this right now seems unfeasible. But I'll keep an eye on it, and also dig somewhat. |
What do you mean by that @srogovtsev ? Doesn't it expose an implementation of |
I mean that while it exposes an implementation of Using |
I just had a quick poke around, I think the needed API is still |
+1 |
Closing as this isn't something we can implement here in this repo, but feel free to drop a link in here if you build or spot one of these out there. Thanks for the discussion @srogovtsev 👍 |
First, I want to make clear that this is not a feature request for
Serilog.Sinks.OpenTelemetry
, as this is very obviously contrary to its original design decision. It's just that I haven't found a better place to ask this question.Is there any Serilog sink implementation that would rely on OpenTelemetry SDK?
The rationale is that if the system already uses OpenTelemetry SDK, the dependencies are not an issue, and going through the SDK for logs would allow them to share settings and, e.g., Resource definitions.
The text was updated successfully, but these errors were encountered: