Add new mechanism to enable creation of DiagnosticContext scopes #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP proposal to fix #47. There's still a few unanswered questions below as I'm not sure this is 100% the right direction :).
It introduces a new method to
IDiagnosticContext
that allows users to begin a newDiagnosticContextScope
that collects properties viaIDiagnosticContext
:Open Questions
There's still a number of areas that haven't been fully thought through on the interface method:
RequestLoggingMiddleware
)?IDiagnosticContext
isn't the right place forBegin
, and that maybe it belongs on some other thing that should be injected to keep IDC clean. Putting it onILogger
might work, but then you'd need to pass in anIDiagnosticContext
.Sample Usage
Which produces this event: