-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use VS2017/.Net Core tooling #47
Comments
Hi @patriklindstrom, Thanks for dropping by. I assume you are opening this within the latest VS2017 with .Net Core tooling support. We are working through this in all our repos/sinks (>50) however it is taking some time. Please bear with us. Please feel free to provide a PR, we have just not got to this sink as yet. The change would include not just files but updates to
|
@merbla thanks for quick reply. Ill try to look into it. |
I will dig around another sink conversion as an example. |
I found this info for the error for Visual Studio ".NET Cord SDK Not found...." https://github.com/aspnet/Tooling/blob/master/known-issues-vs2015.md#missing-sdk . See if it will help me get further. |
Reference PR for migration. |
I get errors like: src\sample\project.json: Failed to migrate XProj project Sample. Could not find project.json at L:\Dev\serilog-sinks-splunk\src\sample\project.json.
and
serilog-sinks-splunk.sln: Visual Studio needs to make non-functional changes to this project in order to enable the project to open in released versions of Visual Studio newer than Visual Studio 2010 SP1 without impacting project behavior.
The text was updated successfully, but these errors were encountered: