Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a proxy #32

Closed
Wedvich opened this issue Oct 5, 2016 · 3 comments
Closed

Allow setting a proxy #32

Wedvich opened this issue Oct 5, 2016 · 3 comments

Comments

@Wedvich
Copy link
Contributor

Wedvich commented Oct 5, 2016

I'm currently working on a project for a client where all outbound HTTP calls need to go through a proxy server. I see that an HttpClient is used internally in the sink, but there's no injection point for a HttpMessageHandler anywhere. I suggest another optional parameter in the EventCollector constructor and extension method: proxyAddress, which is exactly what it looks like. This can then be passed in to the EventCollectorClient constructor and be used to create a HttpClientHandler using the provided proxy.

I'd be happy to create a PR for this.

@merbla
Copy link
Contributor

merbla commented Oct 5, 2016

@Wedvich sounds great. Similar to #26 we need to open up HttpMessageHandler

@merbla
Copy link
Contributor

merbla commented Oct 5, 2016

@merbla
Copy link
Contributor

merbla commented Oct 6, 2016

Great work @Wedvich now to get a release out.

@merbla merbla closed this as completed Oct 6, 2016
@merbla merbla mentioned this issue Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants