Setting NumberOfReplicas to 0 does not have any effect

[ffMathy]

Setting NumberOfReplicas to 0 in the ElasticsearchSinkOptions does not work. Only if the value is higher.

0 should still be a valid value, and the value is also a nullable integer currently, so I think this is a bug.

[tresoldigiorgio]

it woks for me with this settings:
{ "Name": "Elasticsearch", "Args": { "nodeUris": "http://localhost:9200", "indexFormat": "auditlog-{0:yyyy.MM}", "numberOfShards": 1, "numberOfReplicas": 0, "overwriteTemplate": true, "autoRegisterTemplate": true, "autoRegisterTemplateVersion": "ESv6", "numberOfShards": 1, "numberOfReplicas": 0 } }

[ffMathy]

Not via the ElasticsearchSinkOptions object. I'm not talking about JSON configuration.

[ffMathy]

Example:

loggerConfiguration.WriteTo.Elasticsearch(new ElasticsearchSinkOptions(elasticsearchBaseUrl)
                {
                    Period = TimeSpan.FromSeconds(10),
                    NumberOfReplicas = 0,
                    NumberOfShards = 5,
                    BatchPostingLimit = 100,
                    AutoRegisterTemplate = true,
                    MinimumLogEventLevel = LogEventLevel.Verbose,
                    AutoRegisterTemplateVersion = AutoRegisterTemplateVersion.ESv6,
                    CustomFormatter = new ExceptionAsObjectJsonFormatter(
                        renderMessage: true,
                        serializer: new JsonNetSerializer(
                            new LowLevelRequestResponseSerializer(),
                            new ConnectionSettings(elasticsearchBaseUrl),
                            modifyContractResolver: x =>
                                x.NamingStrategy = new CamelCaseNamingStrategy(),
                            jsonSerializerSettingsFactory: () =>
                                new JsonSerializerSettings
                                {
                                    TypeNameHandling = TypeNameHandling.None
                                }))
                })

The above will set number of replicas to 1.

[mivano]

Strange, 0 should be valid, but looks like it marks it as null and as such outputs the default value of 1. Care for a PR?

[ffMathy]

I don't have time unfortunately :(

[mivano]

See #301
Old issue, cleaning up. Still facing this issue, feel free to reopen.