Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

Listing react as a peerDependency instead of dependency #11

Closed
Erigers opened this issue Feb 15, 2018 · 2 comments
Closed

Listing react as a peerDependency instead of dependency #11

Erigers opened this issue Feb 15, 2018 · 2 comments

Comments

@Erigers
Copy link

Erigers commented Feb 15, 2018

Hi there,
I've used your package in a project and it seems to fail the image loading, enter in the onError callback with this error:
this.updater.enqueueCallback is not a function
even though the image exists.
I've been looking around for the cases this error was thrown and this react issue thread explains that the package installation brings an older version than react since it's listed as a dependency not as a peerDependency:
facebook/react#10320 (comment)
Please, can you apply this quick fix ?

@sergiodxa
Copy link
Owner

@Erigers
Copy link
Author

Erigers commented Feb 15, 2018

screen shot 2018-02-15 at 8 25 32 pm

When I install react-lazy-image via npm, this is what I see in `node_modules/react-lazy-image/package.json`. Is this how it's supposed to be?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants