Improve tokens semantics and clean up gateway feature gates #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
mkrasnitski
force-pushed
the
token-rework
branch
2 times, most recently
from
c4b13f2 to
0bccd4c
Compare
mkrasnitski
force-pushed
the
token-rework
branch
from
0bccd4c to
5de6e13
Compare
GnomedDev
reviewed
Nov 19, 2024
There was a problem hiding this comment.
This looks mainly good just some minor issues:
- Can you add a
Token::from_env("DISCORD_TOKEN")helper for the examples? - Can you remove the
Http::defaultimplementation, and haveHttp::newtake the token with aHttp::wthout_tokenconstructor for webhook-only use, since this is the super minority of use cases.
|
Done. |
GnomedDev
reviewed
Nov 20, 2024
mkrasnitski
force-pushed
the
token-rework
branch
from
8277ca4 to
e62f1aa
Compare
GnomedDev
reviewed
Nov 20, 2024
Comment on lines
+50
to
+53
| /// An error from the [`secrets`] module. | ||
| /// | ||
| /// [`secrets`]: crate::secrets | ||
| Token(TokenError), |
There was a problem hiding this comment.
Does this have to be a part of this enum? I can't see a spot that returns this instead of just Result<T, TokenError>.
There was a problem hiding this comment.
I figured this would be useful when using ? so that TokenError could coerce to Error.
GnomedDev
approved these changes
Nov 22, 2024
mkrasnitski
added
the
breaking change
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This divorces the gateway feature from the model/http code such that there is no cross-contamination (setting the stage for a crate split). A few doctests got rewritten to not rely on the gateway, and the
Http::tokenmethod was removed. The gateway structs now carry their own copy of the token, and the Http token field was made optional for users who only care about webhooks.Furthermore, renamed the
secret_stringmodule tosecretsand added aTokentype that can partially validate token strings. This type is what is now passed in to the client. The user is expected to call eitherstr::parse::<Token>()orToken::from_strin order to create a Client.