-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundboard #3045
Soundboard #3045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the builders, any Option
fields should be marked #[serde(skip_serializing_if = "Option::is_none")]
. Also audit_log_reason
should be marked #[serde(skip)]
.
Fixed |
|
The reason it targets next is because I really don’t want to touch serenity current which I basically have never touched in the past year or so. Also, all of my discord bots use next so there’s no point in me touching current as for 2, yeah, will do |
I am not going to merge this non-breaking change that doesn't rely on changes made to next into next. New discord features go to current, so they can be released as a minor version. |
With james's suggestion on discord about making a test bot, will open a new PR against current for this |
Implements the soundboard. Might be mangled with my PR on
delete_message_seconds