Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundboard #3045

Closed
wants to merge 18 commits into from
Closed

Conversation

cheesycod
Copy link
Contributor

Implements the soundboard. Might be mangled with my PR on delete_message_seconds

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. http Related to the `http` module. gateway Related to the `gateway` module. labels Nov 18, 2024
Copy link
Collaborator

@mkrasnitski mkrasnitski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the builders, any Option fields should be marked #[serde(skip_serializing_if = "Option::is_none")]. Also audit_log_reason should be marked #[serde(skip)].

@cheesycod
Copy link
Contributor Author

For the builders, any Option fields should be marked #[serde(skip_serializing_if = "Option::is_none")]. Also audit_log_reason should be marked #[serde(skip)].

Fixed

@GnomedDev
Copy link
Member

  1. Why is this targeting next?
  2. Yes, you have included part of Replace bans delete_message_days with delete_message_seconds #3044, please rebase it away.

@cheesycod
Copy link
Contributor Author

cheesycod commented Nov 19, 2024

  1. Why is this targeting next?
  2. Yes, you have included part of Replace bans delete_message_days with delete_message_seconds #3044, please rebase it away.

The reason it targets next is because I really don’t want to touch serenity current which I basically have never touched in the past year or so. Also, all of my discord bots use next so there’s no point in me touching current

as for 2, yeah, will do

@GnomedDev
Copy link
Member

I am not going to merge this non-breaking change that doesn't rely on changes made to next into next. New discord features go to current, so they can be released as a minor version.

@cheesycod cheesycod closed this Nov 19, 2024
@cheesycod
Copy link
Contributor Author

With james's suggestion on discord about making a test bot, will open a new PR against current for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder Related to the `builder` module. gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants