Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde 1.0.119 breaks semantic versioning. #1946

Closed
ryzhyk opened this issue Jan 11, 2021 · 1 comment
Closed

serde 1.0.119 breaks semantic versioning. #1946

ryzhyk opened this issue Jan 11, 2021 · 1 comment

Comments

@ryzhyk
Copy link

ryzhyk commented Jan 11, 2021

serde release 1.0.119 changes the public interface of the serde library without advancing its minor version number. Specifically, it no longer exposes the export module that used to re-export various bits of the standard library. Unfortunately, this breaks a released version of my software.

@dtolnay
Copy link
Member

dtolnay commented Jan 11, 2021

Semver only applies to public APIs. That module is an internal implementation detail that has always been hidden and commented "not public API", so it has no bearing on semantic versioning and is not supposed to be used externally.

serde/serde/src/lib.rs

Lines 267 to 269 in e797431

// Generated code uses these to support no_std. Not public API.
#[doc(hidden)]
pub mod export;

@dtolnay dtolnay closed this as completed Jan 11, 2021
@serde-rs serde-rs locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants