esm: remove support for deprecated hooks

Those have been deprecated for a while, it's time. PR-URL: nodejs/node#47580 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
sercher · Apr 25, 2024 · 53ea02b · 53ea02b
1 parent 740eae8
commit 53ea02b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 87 deletions.
diff --git a/graal-nodejs/lib/internal/modules/esm/hooks.js b/graal-nodejs/lib/internal/modules/esm/hooks.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const {
-  ArrayPrototypeJoin,
   ArrayPrototypePush,
   FunctionPrototypeCall,
   Int32Array,
@@ -658,45 +657,9 @@ function pluckHooks({
   globalPreload,
   resolve,
   load,
-  // obsolete hooks:
-  dynamicInstantiate,
-  getFormat,
-  getGlobalPreloadCode,
-  getSource,
-  transformSource,
 }) {
-  const obsoleteHooks = [];
   const acceptedHooks = { __proto__: null };
 
-  if (getGlobalPreloadCode) {
-    globalPreload ??= getGlobalPreloadCode;
-
-    process.emitWarning(
-      'Loader hook "getGlobalPreloadCode" has been renamed to "globalPreload"',
-    );
-  }
-  if (dynamicInstantiate) {
-    ArrayPrototypePush(obsoleteHooks, 'dynamicInstantiate');
-  }
-  if (getFormat) {
-    ArrayPrototypePush(obsoleteHooks, 'getFormat');
-  }
-  if (getSource) {
-    ArrayPrototypePush(obsoleteHooks, 'getSource');
-  }
-  if (transformSource) {
-    ArrayPrototypePush(obsoleteHooks, 'transformSource');
-  }
-
-  if (obsoleteHooks.length) {
-    process.emitWarning(
-      `Obsolete loader hook(s) supplied and will be ignored: ${
-        ArrayPrototypeJoin(obsoleteHooks, ', ')
-      }`,
-      'DeprecationWarning',
-    );
-  }
-
   if (globalPreload) {
     acceptedHooks.globalPreload = globalPreload;
   }

diff --git a/graal-nodejs/test/es-module/test-esm-loader-obsolete-hooks.mjs b/graal-nodejs/test/es-module/test-esm-loader-obsolete-hooks.mjs
diff --git a/graal-nodejs/test/fixtures/es-module-loaders/hooks-obsolete.mjs b/graal-nodejs/test/fixtures/es-module-loaders/hooks-obsolete.mjs