Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in rnaseq.rules #12

Closed
PierreL-B opened this issue Jan 3, 2022 · 2 comments
Closed

Error in rnaseq.rules #12

PierreL-B opened this issue Jan 3, 2022 · 2 comments
Assignees

Comments

@PierreL-B
Copy link

Hi Thomas,

I just came across a typo in rnaseq.rules, line 279:
Instead of
"adapter_tool = manager.config.cutadapt.software_choice",
which returns an error for now, it should be:
"adapter_tool = manager.config.trimming.software_choice"

Happy New Year !
Cheers,
Pierre

@cokelaer
Copy link
Contributor

cokelaer commented Jan 5, 2022

Hi Pierre, happy new year as well !
well spotted. Indeed, this is a typo.
We are now exclusively using fastp for trimming and adapter removal, which explain why we have not seen this issue. I'll try to add a test to catch this regression bug. I'll do a release in a couple of days to fix this issue. I'll let you know once on github and pypi
cheers

@cokelaer
Copy link
Contributor

The new pipelines is now online on pypi (v0.15.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants