From 76baa447ecd09536d485aa2e0a87610770254232 Mon Sep 17 00:00:00 2001 From: smehringer Date: Fri, 15 May 2020 11:41:35 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Enrico Seiler --- include/seqan3/search/detail/search_scheme_algorithm.hpp | 2 +- .../seqan3/search/detail/unidirectional_search_algorithm.hpp | 2 +- test/unit/search/configuration/mode_test.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/seqan3/search/detail/search_scheme_algorithm.hpp b/include/seqan3/search/detail/search_scheme_algorithm.hpp index 99da3791d6a..261b4e1be31 100644 --- a/include/seqan3/search/detail/search_scheme_algorithm.hpp +++ b/include/seqan3/search/detail/search_scheme_algorithm.hpp @@ -112,7 +112,7 @@ class search_scheme_algorithm : protected policies_t... search_param error_state, delegate_t const & on_hit_delegate) { - if constexpr (traits_t::search_single_best_hit || traits_t::search_all_best_hits || traits_t::search_strata_hits) + if constexpr (!traits_t::search_all_hits) { auto max_total = error_state.total; error_state.total = 0; // start search with less errors diff --git a/include/seqan3/search/detail/unidirectional_search_algorithm.hpp b/include/seqan3/search/detail/unidirectional_search_algorithm.hpp index cdea66a1cf1..feb47c3c7e9 100644 --- a/include/seqan3/search/detail/unidirectional_search_algorithm.hpp +++ b/include/seqan3/search/detail/unidirectional_search_algorithm.hpp @@ -129,7 +129,7 @@ class unidirectional_search_algorithm : protected policies_t... query_t & query, search_param error_state) { - if constexpr (traits_t::search_single_best_hit || traits_t::search_all_best_hits || traits_t::search_strata_hits) + if constexpr (!traits_t::search_all_hits) { auto max_total = error_state.total; error_state.total = 0; // start search with less errors diff --git a/test/unit/search/configuration/mode_test.cpp b/test/unit/search/configuration/mode_test.cpp index c95781f827d..089886cadef 100644 --- a/test/unit/search/configuration/mode_test.cpp +++ b/test/unit/search/configuration/mode_test.cpp @@ -7,8 +7,8 @@ #include -#include #include +#include #include "../../core/algorithm/pipeable_config_element_test_template.hpp"