Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignemnt Configuration] Put align_cfg::debug into align_cfg::detail::debug #181

Closed
10 tasks
rrahn opened this issue Aug 7, 2020 · 1 comment · Fixed by seqan/seqan3#2020
Closed
10 tasks
Assignees
Labels
ready to tackle This story was discussed and can be immidietly tackled

Comments

@rrahn
Copy link
Contributor

rrahn commented Aug 7, 2020

Description

We want the align_cfg::detail subnamespace for alignment configurations.
Here is the proposed change of the interface:

seqan3::align_cfg::detail::debug    [optional]
usage: seqan3::align_cfg::detail::debug

construction - no construction since it is a tag

seqan3::align_cfg::detail::debug;
// this is an instance of seqan3::align_cfg::detail::debug_tag     

access by seqan::get:

auto && var = seqan3::get<seqan3::align_cfg::detail::debug_tag>(config);

check if present:

constexpr bool in_debug_mode = config_t::template exists<seqan3::align_cfg::detail::debug_tag>();

Acceptance Criteria

  • Introduce and documented subnamespace align_cfg::detail

Tasks

  • Put the debug option into seqan3::align_cfg::detail subnamespace.

Definition of Done

  • Implementation and design approved
  • Unit tests pass
  • Test coverage = 100%
  • Microbenchmarks added and/or affected microbenchmarks < 5% performance drop
  • API documentation added
  • Tutorial/teaching material added
  • Test suite compiles in less than 30 seconds (on travis)
  • Changelog entry added
@rrahn rrahn added the ready to tackle This story was discussed and can be immidietly tackled label Aug 7, 2020
@Irallia Irallia self-assigned this Aug 10, 2020
@smehringer
Copy link
Member

Fixed by seqan/seqan3#2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to tackle This story was discussed and can be immidietly tackled
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants