Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font_size_splitter bug #257

Closed
sepandhaghighi opened this issue Aug 28, 2023 · 3 comments · Fixed by #261
Closed

font_size_splitter bug #257

sepandhaghighi opened this issue Aug 28, 2023 · 3 comments · Fixed by #261
Assignees
Labels
Milestone

Comments

@sepandhaghighi
Copy link
Owner

Description

The font_size_splitter function cannot be reproduced.

Steps/Code to Reproduce

>>> from art import *
>>> import random
>>> random.seed(200)
>>> tprint("test", "random-large")

Expected Behavior

The output remains the same in each session (within the same version)

Actual Behavior

Different outputs

Operating System

Windows 10

Python Version

Python 3.8

ART Version (Use : art.__version__)

ART 6.0

@sepandhaghighi sepandhaghighi added this to the art 6.1 milestone Aug 28, 2023
@sepandhaghighi
Copy link
Owner Author

Sometimes, this problem can result in test failures.
We should sort fonts variable:

art/art/art.py

Line 27 in 5be3f0d

fonts = set(font_map.keys()) - set(RANDOM_FILTERED_FONTS)

@sepandhaghighi
Copy link
Owner Author

@sadrasabouri Are you interested in handling this issue?

@sadrasabouri
Copy link
Collaborator

Yeah sure.

@sadrasabouri sadrasabouri self-assigned this Aug 28, 2023
@sepandhaghighi sepandhaghighi linked a pull request Sep 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants