handler hash ordering causing unneeded changes

[ghost]

Notice: /Stage[main]/role_sensu::Server/Sensu::Handler[relay]/Sensu_handler[relay]/socket: socket changed {'port' => '2003', 'socket' => 'carbon.hostedgraphite.com'} to '{"socket"=>"carbon.hostedgraphite.com", "port"=>2003}'

I believe this is caused by the handler type taking a hash for the socket attribute. Due to the non-deterministic ordering of the hash retrieval you see frequent 'changes' where no actual change occurs. This causes the puppet enterprise dashboard to permanently list the node as recently changed.

This should be fixable by sorting the socket hash before using it within the json.

[jlambert121]

@robertpearce are you able to send a PR for this fix? If not, I'll add it to my TODO list.

[ghost]

don't know ruby, sorry :( i tried a .sort() in a several places but didn't get it right enough to work how i expected.

[danshultz]

@jlambert121 @robertpearce - I have also addressed this issue with my fix in issue #160

[jlambert121]

closed via #160