Linter does not show file names or line numbers

[echlebek]

Expected Behavior

The golang-ci linter should show each failure in the file and line number it was encountered at.

Current Behavior

The linter simply reports failure, leaving the user to hunt for the lint themselves.

Possible Solution

???

[nikkictl]

Okay, looks like if you go to the github actions tab for the run (see https://github.com/sensu/sensu-go/actions/runs/173965429 for example), it will print out the line number responsible for the lint error. The log should definitely have that in there regardless, but thought I would share this workaround in the meantime.

[nikkictl]

If you read golangci-lint-action, they mention that lint failures are shown as annotations. These annotations are listed in the high level breakdown of the golangci-lint github action (see previous comment), and also displayed in commits and code reviews (see file comparison below).

While the UX is a little counterintuitive, there isn't anything we can do from our CI to resolve this. golangci/golangci-lint-action#5 exists to create code review comments for lint issues, but has not yet been implemented.

I'm going to close out this issue, but use #3928 and https://github.com/sensu/sensu-enterprise-go/pull/1157 to bump the dependencies to the most current.