Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal from Ansible (Community package requirements: sanity tests and repository management) #362

Open
gotmax23 opened this issue Jan 23, 2024 · 3 comments
Assignees

Comments

@gotmax23
Copy link

(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 1.14.0 of sensu.sensu_go, corresponding to the v1.14.0 tag in this repo, fails one or more of the required sanity tests.

The contents in the v1.14.0 git tag do not match sensu-sensu_go-1.14.0.tar.gz as uploaded to Ansible Galaxy. For future releases, please make sure that the contents uploaded to Galaxy match the sources that were tagged as that release. See the Repository management requirements for more information.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.


Sanity tests

The following tests were run using ansible-test version 2.16.1:

  • ansible-doc
  • compile
  • validate-modules
  • yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

💡 NOTE:

Check the [explain] links below for more information about each test and how to fix failures.
See Sanity Tests: Ignores in the dev guide if, after reading the test-specific documentation, you still believe an error is a false positive.

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'annotations' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'auth' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'labels' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'namespace' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'on_remote' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/bonsai_asset.py:0:0: nonexistent-parameter-documented: Argument 'rename' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
plugins/modules/datastore.py:0:0: doc-default-does-not-match-spec: Argument 'pool_size' in argument_spec defines default as (0) but documentation defines default as (None)

File divergences

The following files differ between the v1.14.0 git tag and sensu-sensu_go-1.14.0.tar.gz on Ansible Galaxy:

  • docs/source/release_notes.rst (WRONG_HASH)
@gotmax23
Copy link
Author

Please take a look at the outstanding sanity test errors. https://github.com/ansible-community/package-test-results/blob/main/rendered/10.3.0/sensu.sensu_go.md contains the results for the latest version of ansible. Note that, if these issues aren't acknowledged within a reasonable time period, the collection may be subject to removal from Ansible.

@gotmax23 gotmax23 changed the title Community package requirements: sanity tests and repository management Removal from Ansible (Community package requirements: sanity tests and repository management) Sep 9, 2024
@gotmax23
Copy link
Author

gotmax23 commented Sep 9, 2024

https://forum.ansible.com/t/collection-removal-sensu-sensu-go/8380 to start the removal from Ansible process

@sensu-discourse
Copy link

This issue has been mentioned on Sensu Community. There might be relevant details there:

https://discourse.sensu.io/t/official-install-not-working-for-ubuntu-24-04-lts/3246/19

@nasirhussenm nasirhussenm self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants