NTP server time setting

[peza8]

Seems like configTime is unaffected by changing the timezones in the config files, or passing in vars directly. It always seems to pull time with GMT +8 regardless of the arg passed into time set.

AWS IoT Core certs seem to be validated in this window, so functionally it works, but there are definitely errors occurring.

[peza8]

This is the exact issue:

esp8266/Arduino#2505

Time zone is being set to Shanghai time.

[peza8]

The AWS docs on the importance of the client have a correct understanding of time are here.

The important bit:

In order for a device to validate the server certificate presented by AWS IoT Core for an MQTT connection, the device’s time should be within some reasonable distance of the server’s time, e.g. no more than a few hours. Devices connecting using WebSocket/SigV4 authentication have an additional and more stringent requirement on the server side and must be within 15 minutes of the server’s time.

At the moment our time diff is 7 hours, and will become 8 hours on October 27. Need to monitor for connection stability.

[peza8]

A patch in the ESP8266 Arduino library was committed 23 days ago:

esp8266/Arduino#6373 (comment)

[peza8]

Checkpoint facts

---

1. If there will be an issue with the timezones, I would have to pre-empt it. After it's happened I won't be able to trigger an OTA.
2. I should pre-warn the team about the effects, but I'm not going to risk a patch on what may be fine.
3. In future firmware versions we will rectify this issue - add to code review V1.2.4