Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SendGrid addon on Heroku uses Basic Authentication with Username and Password #458

Open
vfonic opened this issue Jan 18, 2021 · 4 comments
Labels
type: non-library issue API issue not solvable via the SDK

Comments

@vfonic
Copy link

vfonic commented Jan 18, 2021

I know this is not the most relevant place to submit this issue, but I got lost trying to find a contact on your website. Now you can close this issue and wait for this to start failing or you can forward it to the right place through your internal channels.
Thank you!

Issue Summary

The Basic Authentication with Username and Password is deprecated and will most likely stop working on January 20th.

However, SendGrid addon on Heroku still uses Basic Authentication. This will cause issues for anyone who tries to add SendGrid addon and use it on Heroku. Developers will have to manually switch from Basic Auth to API key auth.

Steps to Reproduce

  1. Create new app on heroku
  2. Add SendGrid addon
  3. Check environment variables created by SendGrid addon

Actual:

The environment variables created are:

SENDGRID_PASSWORD: 'xxx'
SENDGRID_USERNAME: [email protected]

Expected:

I'd expect something of the kind:

SENDGRID_PASSWORD: 'xxx'
SENDGRID_USERNAME: apikey

or

SENDGRID_API_KEY: 'xxx'

...and update heroku documentation.

Related links

https://devcenter.heroku.com/articles/sendgrid#actionmailer
https://sendgrid.com/docs/for-developers/sending-email/upgrade-your-authentication-method-to-api-keys

@thinkingserious
Copy link
Contributor

Hello @vfonic,

Thank you for taking the time to report this. I have forwarded this information to the appropriate team internally. Thanks again!

With best regards,

Elmer

@thinkingserious thinkingserious added the type: non-library issue API issue not solvable via the SDK label Jan 19, 2021
@vfonic
Copy link
Author

vfonic commented Jan 20, 2021

Thank you, Elmer! 🤘

@vfonic
Copy link
Author

vfonic commented Feb 19, 2021

Well, that doesn't seem like it worked. :/

As of this morning SendGrid plugin is not able to authenticate. I've switched to API authentication manually.

Basically, the SendGrid Heroku addon doesn't work out of the box. The ENV variables that are added to the app are old username/password combination that no longer works.

You guys should work on your internal and external communication. This is the second time in couple of months that I've had negative experience trying to reach out to someone at SendGrid. The first time I couldn't get an answer and so I switched my client to another service. This time the feeling tells me I should switch to more reliable service as well.

@Petercopter
Copy link

This still appears to be a problem :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: non-library issue API issue not solvable via the SDK
Projects
None yet
Development

No branches or pull requests

3 participants